Update SDK for underlying native SDKs alpha.3 version#40
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude finished @tolgahan-arikan's task —— View job PR Review: Update SDK for native SDKs alpha.3Reviewed the TS public API, the iOS/Android/JS bridge layers, auth/signing/tx flows, docs, and tests. Overall this is a clean, well-structured migration to the instance-based Blockers1. Fee-selection token derived differently on iOS vs Android
The Non-blocking issues2.
If the Swift SDK's internal default isn't also MAINNETS, the two platforms will query different network sets for the same JS call. Recommend making the default explicit and identical on both sides (or letting both pass through nil). 3. Android 4. Nits
Things that look good
Test coverage gapTests exercise auth/session/indexer routing well, but there's no coverage for the fee-option selection round-trip ( This is a review only — no code changed. Issue #1 is the one I'd want resolved (or explained) before merge; the rest are confirm-or-fix. |
Summary
new OMSClient({ publishableKey }), instance wallet/indexer namespaces, and no legacy compatibility shimsgetBalancesandgetTransactionHistory0.1.0-alpha.3and align Android Kotlin/KotlinX versions required by the new Kotlin artifactclaude-review.ymlworkflow used by the Swift/Kotlin SDKsRelease prep included
0.1.0-alpha.3io.github.0xsequence:oms-client-kotlin-sdk:0.1.0-alpha.3oms-client-swift-sdk0.1.0-alpha.3CHANGELOG.mdincludes the0.1.0-alpha.3entry dated 2026-06-260.1.0-alpha.1and0.1.0-alpha.2;0.1.0-alpha.3is not published yetValidation
yarn prepareyarn lintyarn typecheckyarn testyarn npm publish --dry-run --access public --tag alpha./gradlew :app:assembleDebuginexamples/sdk-example/android./gradlew :app:assembleDebuginexamples/trails-actions-example/androidOmsClientReactNativeSdkExampleTrailsActionsDemooms.indexer.getBalancesyarn prettier --check README.md API.md PUBLISHING.mdyarn prettier --check .github/workflows/claude-review.yml.github/workflows/claude-review.yml.github/workflows/ci.ymlbundle _2.4.22_ check && bundle _2.4.22_ exec pod --versionin both iOS example bundlesgit diff --checkPublishing steps after merge
master.masterlocally.npm view @0xsequence/oms-react-native-sdk@0.1.0-alpha.3 version. A 404 is expected before publish.masterworktree, run the standard release checks fromPUBLISHING.md.yarn prepareandyarn npm publish --dry-run --access public --tag alphaonmaster.yarn npm whoami.yarn npm publish --access public --tag alpha.npm view @0xsequence/oms-react-native-sdk@0.1.0-alpha.3 version.0.1.0-alpha.3, updateexamples/expo-exampleto depend on the newly published package version.