Skip to content

chore(expo-example): bump SDK to alpha.3#41

Open
tolgahan-arikan wants to merge 2 commits into
masterfrom
update-expo-example-version
Open

chore(expo-example): bump SDK to alpha.3#41
tolgahan-arikan wants to merge 2 commits into
masterfrom
update-expo-example-version

Conversation

@tolgahan-arikan

@tolgahan-arikan tolgahan-arikan commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bump the standalone Expo example dependency on @0xsequence/oms-react-native-sdk from 0.1.0-alpha.2 to 0.1.0-alpha.3.
  • Refresh the Expo example lockfile with the published 0.1.0-alpha.3 tarball metadata.
  • Update the Expo example to use the alpha.3 OMSClient instance API instead of removed top-level helper exports.
  • Use the current demo publishable key and configure Android prebuild to use Kotlin 2.3.20, matching the alpha.3 Android dependency graph.

Impact

The Expo example continues to exercise the published npm artifact and now launches cleanly against the latest alpha release. Android prebuild output also compiles with the Kotlin version required by the alpha.3 native SDK dependencies.

Validation

  • npm run typecheck from examples/expo-example
  • npx expo run:ios --no-bundler from examples/expo-example
  • iOS Simulator launch against Metro on iPhone 17; verified the app screen loaded and SDK initialization log showed Ready. >> Initializing SDK without runtime errors
  • npx expo prebuild --platform android --clean --no-install from examples/expo-example
  • ./gradlew --stop && ./gradlew :app:assembleDebug from examples/expo-example/android

@tolgahan-arikan tolgahan-arikan marked this pull request as ready for review June 26, 2026 12:35
@tolgahan-arikan tolgahan-arikan requested a review from a team June 26, 2026 12:35
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

Claude finished @tolgahan-arikan's task —— View job


Review: PR #41 — bump Expo example to alpha.3

  • Read changed files
  • Verify App.tsx API usage matches alpha.3 public API
  • Check dependency policy (only bump after npm publish)
  • Review Android Kotlin plugin + app.json
  • Post review

Verdict: LGTM. This is an example-only change (examples/expo-example/**); it touches no src/, android/, ios/, API.md, or PUBLISHING.md, so the SDK public API and native bridge are unaffected. No backwards-compat shims introduced.

What I verified

  • API usage matches alpha.3. App.tsx now uses new OMSClient({ publishableKey }) and the instance API (oms.wallet.*, oms.supportedNetworks) instead of removed top-level helpers. Spot-checked against src/:
    • wallet.startEmailAuth / completeEmailAuth → result type discriminants (walletSelection / walletSelected) and pendingSelection.selectWallet|createAndSelectWallet align with src/types.ts:75-102.
    • handleOidcRedirectCallback switch arms (completed/walletSelection/failed/noPendingAuth/notOidcRedirectCallback) match OmsOidcRedirectAuthResult in src/types.ts:104-128.
    • sendTransaction reads txnHash / txnId / status — match OmsSendTransactionResponse (src/NativeOmsClientReactNativeSdk.ts:193-197).
    • startOidcRedirectAuth(...).state, signMessage(chainId, message), verifyMessageSignature({chainId,message,signature}) all consistent.
  • Dependency policy satisfied. package.json and README.md pin 0.1.0-alpha.3, and package-lock.json resolves the real npm tarball with a valid integrity hash (sha512-4Hsf…RCUg==), confirming the version is published before this bump.
  • Android Kotlin plugin (plugins/with-android-kotlin-gradle-plugin-version.js): minimal withProjectBuildGradle mod, regex-pins kotlin-gradle-plugin to the prop version, wrapped in createRunOncePlugin. Reasonable for matching the alpha.3 native graph. app.json sets kotlinVersion: 2.3.20 in both expo-build-properties and the custom plugin.

Nits (non-blocking)

  • Kotlin version duplicated in app.json — once under expo-build-properties.android.kotlinVersion and again as the custom plugin's version prop. Two sources of truth that must be kept in sync; a brief comment or deriving one from the other would avoid future drift. (Verification note: PR confirms a clean :app:assembleDebug.)
  • Plugin regex only rewrites the first classpath('org.jetbrains.kotlin:kotlin-gradle-plugin…') match (String.replace without /g). Fine for the current single-occurrence template; worth knowing if the gradle template ever lists it twice.
  • No automated test coverage for the example (consistent with repo state per TESTING.md); manual validation steps in the PR body cover iOS launch + Android assemble.

Job run · branch update-expo-example-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant