Skip to content

Separate RL configurations into a dedicated config class#4431

Open
SurbhiJainUSC wants to merge 1 commit into
mainfrom
rl_config
Open

Separate RL configurations into a dedicated config class#4431
SurbhiJainUSC wants to merge 1 commit into
mainfrom
rl_config

Conversation

@SurbhiJainUSC

@SurbhiJainUSC SurbhiJainUSC commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR separates RL configurations into its own dedicated configuration class.

Why is this change being made & the problem being solved:
Previously, RL-specific configurations were mixed with the pre-training configurations. As the number of RL-specific features and hyperparameters grows, this mixed approach makes the primary configuration structure bloated and harder to maintain.

Why this is a good solution:
By isolating RL configurations into a dedicated class, we improve the modularity and readability of our configuration management. It enforces a clear separation of concerns, ensuring that non-RL workloads aren't cluttered with RL-specific parameters, and makes RL hyperparameters easier to track and modify independently.

Specific implementation:

  • Created a new dedicated config class specifically for RL parameters.
  • Migrated existing RL configuration variables out of the base config and into this new class.
  • Updated configuration references across the codebase to point to the newly established RL config class.

Tests

Command: https://paste.googleplex.com/5172847176712192

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@SurbhiJainUSC SurbhiJainUSC force-pushed the rl_config branch 9 times, most recently from 14a54b4 to 534f296 Compare July 14, 2026 00:03
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 I'm sorry @SurbhiJainUSC, but I was unable to process your request. Please see the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants