Separate RL configurations into a dedicated config class#4431
Open
SurbhiJainUSC wants to merge 1 commit into
Open
Separate RL configurations into a dedicated config class#4431SurbhiJainUSC wants to merge 1 commit into
SurbhiJainUSC wants to merge 1 commit into
Conversation
14a54b4 to
534f296
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
|
🤖 Hi @SurbhiJainUSC, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Contributor
|
🤖 I'm sorry @SurbhiJainUSC, but I was unable to process your request. Please see the logs for more details. |
igorts-git
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR separates RL configurations into its own dedicated configuration class.
Why is this change being made & the problem being solved:
Previously, RL-specific configurations were mixed with the pre-training configurations. As the number of RL-specific features and hyperparameters grows, this mixed approach makes the primary configuration structure bloated and harder to maintain.
Why this is a good solution:
By isolating RL configurations into a dedicated class, we improve the modularity and readability of our configuration management. It enforces a clear separation of concerns, ensuring that non-RL workloads aren't cluttered with RL-specific parameters, and makes RL hyperparameters easier to track and modify independently.
Specific implementation:
Tests
Command: https://paste.googleplex.com/5172847176712192
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.