Skip to content

ci: prevent transitive skips on scheduled/manual runs#4435

Draft
mesakhcienet wants to merge 1 commit into
mainfrom
fix/ci-cd-fast-error
Draft

ci: prevent transitive skips on scheduled/manual runs#4435
mesakhcienet wants to merge 1 commit into
mainfrom
fix/ci-cd-fast-error

Conversation

@mesakhcienet

@mesakhcienet mesakhcienet commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Description

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

You can also provide a comma-separated list. If you don't want to close a bug but
simply to reference it, use BUGS, e.g.:
BUGS: b/123456

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mesakhcienet mesakhcienet force-pushed the fix/ci-cd-fast-error branch from 04d8211 to 2bd5b3b Compare July 13, 2026 01:29
@mesakhcienet mesakhcienet force-pushed the fix/ci-cd-fast-error branch from 0b1e088 to 1f5d62b Compare July 13, 2026 04:16
@mesakhcienet mesakhcienet changed the title ci: prevent transitive skips on scheduled runs when code quality or d… ci: prevent transitive skips on scheduled runs Jul 13, 2026
@mesakhcienet mesakhcienet changed the title ci: prevent transitive skips on scheduled runs ci: prevent transitive skips on scheduled/manual runs Jul 13, 2026
tpu7x-tests:
name: TPU7X tests
needs: [build_and_upload_maxtext_package, gate_test_run]
if: github.ref == 'refs/heads/main' && (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch')

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert github.ref == 'refs/heads/main' once the tests are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant