[draft] gmm v2 quantization#4451
Draft
shuningjin wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrate quantization of Tokamax GMM V2. This is joint effort with @CaptainO5
What this does
use_gmm_v2_fwd,use_gmm_v2_dlhs,use_gmm_v2_drhssrc/maxtext/kernels/megablox/ops.pygmmchecks agaisnt empty rule to ensure quantization is applied;use_qwix_quantizationonly whenquantizationis enabled.save_checkpoint_on_startto allow skipping.Tests
Unit test: smoke train
Unit test: gradient equivalence
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.