Skip to content

[codex] Pin agent-core v0.7 insight contract#33

Merged
Svaag merged 1 commit into
mainfrom
codex/agent-core-v0.7-contract
Jul 2, 2026
Merged

[codex] Pin agent-core v0.7 insight contract#33
Svaag merged 1 commit into
mainfrom
codex/agent-core-v0.7-contract

Conversation

@Svaag

@Svaag Svaag commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pin agent-core to the released v0.7.0 insight contract.
  • Add Engineering Loop insight fixture validation and local builders that emit the released contract shape.

Validation

  • uvx ruff check src tests
  • uv run --group dev mypy --strict src
  • TMPDIR=/tmp uv run --group dev python -m pytest -q
  • uv run --group dev hyrule-engineering-loop evals run --strict

@Svaag Svaag marked this pull request as ready for review July 2, 2026 19:40
@Svaag Svaag merged commit 86fa34f into main Jul 2, 2026
4 checks passed
@Svaag Svaag deleted the codex/agent-core-v0.7-contract branch July 2, 2026 19:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf6865a66e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +220 to +221
if routing_decision in {"allow_candidate", "allow_approved"}:
return "draft"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't map candidate-only routing to draft

When the Governor returns allow_candidate, it intentionally leaves the issue at loop:candidate for human review, while only loop:approved is consumed by the daemon for draft PR work. This branch records both allow_candidate and allow_approved as action_selected="draft", so insight logs or arbitration built on these records will report/learn a draft action for issues that were not approved to draft. Reserve draft for allow_approved and use a human-facing action for allow_candidate.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant