Harden loop self-observability#36
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 401d732b0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 1, | ||
| int(config.max_wall_clock_minutes_per_run * multiplier), | ||
| ) | ||
| budget["max_cost_usd"] = round(config.max_cost_usd_per_run * multiplier, 4) |
There was a problem hiding this comment.
With the default daemon config, max_cost_usd_per_day is $10 and max_cost_usd_per_run is $5, but a loop:budget-xl issue now hands the runner a $20 max_cost_usd before any cap against the ledger. daemon_once only checks whether the existing ledger is already over the daily cap before launching the run, so a single labeled issue can exceed the supposedly hard per-day cost budget unless the operator also raises the daily limit. Please cap this value by the remaining daily budget or reject the tier when it would exceed it.
Useful? React with 👍 / 👎.
| update["gate_commands"] = select_gate_commands_for_mutations( | ||
| changed_paths or list(mutations) | ||
| changed_paths or list(mutations), | ||
| cwd=_gate_selection_cwd(state), |
There was a problem hiding this comment.
When a run has multiple promotion worktrees, this chooses a single gate command list using only the first worktree's pyproject.toml, but gate_execution_node later runs that same list in every worktree. If the first repo has a dev group/extra and another repo does not, the later repo will fail on uv run --group/--extra dev ... even when its own changes do not require that setup. Build gates per worktree or avoid using one repo's dependency layout globally.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Closes #6
Closes #11
Closes #12
Closes #13