Disable window sounds in PopupSystem#113
Open
Haselnussbomber wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PopupSystemwindow plays a sound effect when it opens, which happens every time the game starts and the plugin loads.The window open/close sound effects are a 3 year old Dalamud feature, which is sadly not enabled by default.
It can be enabled in the Dalamud Settings under Look & Feel -> Enable sound effects for plugin windows.
This PR adds a single line to disable window sounds for this popup.
Would be nice if we can disable this. Thanks! ✌️
(I honestly don't know what git is doing there, lol. It's only one line more.^^)