Skip to content

[O2B-1561] Alter filter popup button to have a drop down function where the user can copy, paste and clear the filters#2146

Merged
graduta merged 20 commits into
mainfrom
feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters
Jun 18, 2026
Merged

[O2B-1561] Alter filter popup button to have a drop down function where the user can copy, paste and clear the filters#2146
graduta merged 20 commits into
mainfrom
feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters

Conversation

@NarrowsProjects

@NarrowsProjects NarrowsProjects commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • The filter toggle button how has a drop-down next to it that allows them to copy, paste, and reset filters

Notable changes for developers:

  • FilteringModel now has an enum with the keys for the different warnings it handles
  • A new warning type has been added where the user tries to paste a filter string on the wrong page
  • FilteringModel.setFiltersFromURL has a new 'url' argument that if set, will be used in place of the router.params
  • A significant refactor has been done on theSetFiltersFromURL functioni.
    • The filter setting loop has been moved to it's own function called _setFilters
    • The warnings are now cleared before anything else and re-applied as needed
  • All OverviewPageModels have the setFiltersFromURL function now.

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 29, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 29, 2026
@NarrowsProjects NarrowsProjects changed the base branch from main to feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url April 29, 2026 15:09
Comment thread lib/public/components/Filters/common/FilteringModel.js Fixed
Comment thread lib/public/components/Filters/common/FilteringModel.js Fixed
@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.61%. Comparing base (dda6153) to head (68e0918).

Files with missing lines Patch % Lines
...public/components/Filters/common/FilteringModel.js 0.00% 35 Missing ⚠️
...c/components/Filters/common/filtersPanelPopover.js 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
- Coverage   45.69%   45.61%   -0.08%     
==========================================
  Files        1038     1038              
  Lines       17302    17334      +32     
  Branches     3147     3152       +5     
==========================================
+ Hits         7906     7907       +1     
- Misses       9396     9427      +31     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch 4 times, most recently from 97b6860 to 1462d23 Compare April 30, 2026 08:03
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url branch from 816bc17 to dcd336b Compare June 12, 2026 14:42
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url branch 2 times, most recently from 9e87615 to faecb90 Compare June 12, 2026 15:07
Base automatically changed from feature/O2B-1559/Warn-the-user-of-mutated-filters-when-loading-the-url to main June 16, 2026 13:41
Comment thread test/public/Filters/index.js Fixed
Comment thread test/public/components/warnings.test.js Fixed
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch from 7ffcb4d to 6c1b59e Compare June 17, 2026 10:48

@graduta graduta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing I discovered the following major issue:

  1. Go to an overview table page, let's say runs
  2. Add a filter option, any
  3. Use the "Copy Active Filters" button from the filter dropdown
  4. Navigate to another overview table page, let's say LhcFills
  5. Use the "Paste" button from the filter dropdown.
  6. Observe how the URL changed the parameter for the page to runs and filter parameters, but we are currently still on the page LHC Fills

@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch from 38c1c23 to b42bb37 Compare June 17, 2026 20:18
@NarrowsProjects

NarrowsProjects commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

While testing I discovered the following major issue:

  1. Go to an overview table page, let's say runs
  2. Add a filter option, any
  3. Use the "Copy Active Filters" button from the filter dropdown
  4. Navigate to another overview table page, let's say LhcFills
  5. Use the "Paste" button from the filter dropdown.
  6. Observe how the URL changed the parameter for the page to runs and filter parameters, but we are currently still on the page LHC Fills

I've changed the behavior to cancle the filter setting if it finds that the page of the url does not match up with the current page.

In addition, I've added a warning for this specific scenario
image (1)

Comment thread lib/public/components/Filters/common/FilteringModel.js Outdated
Comment thread lib/public/components/Filters/common/filtersPanelPopover.js Outdated
Comment thread test/public/components/filtersPopoverPanel.test.js Outdated
Comment thread test/public/components/filtersPopoverPanel.test.js Outdated
Comment thread test/public/components/filtersPopoverPanel.test.js
Comment thread test/public/components/warnings.test.js Fixed
Comment thread test/public/components/warnings.test.js Fixed
Comment thread test/public/components/filtersPopoverPanel.test.js Fixed
Comment thread test/public/components/filtersPopoverPanel.test.js Fixed
Comment thread test/public/components/warnings.test.js Fixed
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch from a95c2f4 to 3d0791e Compare June 18, 2026 09:08
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch from 3d0791e to eb19547 Compare June 18, 2026 09:08
@NarrowsProjects NarrowsProjects requested a review from graduta June 18, 2026 09:31
@graduta graduta merged commit 9d7bf56 into main Jun 18, 2026
39 of 42 checks passed
@graduta graduta deleted the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch June 18, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants