Skip to content

[O2B-1560] Add filter is active indicator to the UI#2147

Merged
graduta merged 6 commits into
mainfrom
feature/O2B-1560/Add-filter-is-active-indicator-to-the-UI
Jun 18, 2026
Merged

[O2B-1560] Add filter is active indicator to the UI#2147
graduta merged 6 commits into
mainfrom
feature/O2B-1560/Add-filter-is-active-indicator-to-the-UI

Conversation

@NarrowsProjects

@NarrowsProjects NarrowsProjects commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • An indicator has been added to the toolbar next to the filter button/dropdown
    • When filters are active, this indicator turns green and starts 'glowing'
    • The indicator has a red 'x' icon next to it that glows red. When pressed, the filters are cleared

Notable changes for developers:

  • A fix that was missed in previous branches is that the mcReproducable toggle filter is now considered inactive when untoggled, yet still not 'empty' so it is added to requests

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 30, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 30, 2026
@NarrowsProjects NarrowsProjects changed the base branch from main to feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters April 30, 2026 10:37
Comment thread lib/public/components/Filters/common/filtersPanelPopover.js Fixed
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.57%. Comparing base (9d7bf56) to head (c8a1e40).

Files with missing lines Patch % Lines
...c/components/Filters/common/filtersPanelPopover.js 0.00% 15 Missing ⚠️
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2147      +/-   ##
==========================================
- Coverage   45.61%   45.57%   -0.04%     
==========================================
  Files        1038     1038              
  Lines       17334    17348      +14     
  Branches     3152     3159       +7     
==========================================
  Hits         7907     7907              
- Misses       9427     9441      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1560/Add-filter-is-active-indicator-to-the-UI branch from 3d3fc06 to 49cfbdc Compare April 30, 2026 10:47
@NarrowsProjects NarrowsProjects changed the title Feature/o2 b 1560/add filter is active indicator to the UI [O2B-1560] Add filter is active indicator to the UI Apr 30, 2026
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch from 7ffcb4d to 6c1b59e Compare June 17, 2026 10:48
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters branch from 3d0791e to eb19547 Compare June 18, 2026 09:08
Base automatically changed from feature/O2B-1561/Alter-filter-popup-button-to-have-a-drop-down-function-where-the-user-can-copy,-paste-and-clear-the-filters to main June 18, 2026 09:36
Comment thread lib/public/components/Filters/common/filtersPanelPopover.js Fixed
Comment thread lib/public/components/Filters/common/filtersPanelPopover.js Fixed
Comment thread test/public/Filters/index.js Fixed
Comment thread test/public/components/warnings.test.js Fixed
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1560/Add-filter-is-active-indicator-to-the-UI branch from 31a3b32 to 505156d Compare June 18, 2026 10:10
@graduta graduta merged commit 5c204e2 into main Jun 18, 2026
23 of 25 checks passed
@graduta graduta deleted the feature/O2B-1560/Add-filter-is-active-indicator-to-the-UI branch June 18, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants