feat(env): add .env scaffolding and profile preset support#23
Conversation
wax911
left a comment
There was a problem hiding this comment.
Review notes against #14:
The PR body only claims discovery, listing missing files, recreate, force behavior, and non-secret scaffolding. The issue had several additional acceptance paths that need to be either implemented or explicitly deferred:
--pathsfiltering for explicit service directories/files.--profile dev --materialize/--from-profile devbehavior.env doctorwith sensitive plaintext warnings.- Status listing that distinguishes example files, active plaintext env files, encrypted env files, and profile variants.
- Backup behavior before forced overwrite.
- Dry-run coverage for every mutating path.
Please update the PR body and tests to prove these are covered, or narrow the issue/PR scope so it does not close #14 prematurely.
wax911
left a comment
There was a problem hiding this comment.
Follow-up review after the push:
This PR is now draft, which is appropriate, but it is still not ready:
-
It still targets
mainand carries a cumulative diff. Retarget it to the correct predecessor branch once the stack order is settled. -
The PR body still only claims the smaller env subset and does not mention the previously missing acceptance paths:
--paths, profile materialization,env doctor, sensitive plaintext warnings, forced-overwrite backups, and dry-run coverage. -
Because the body still says
Closes #14, it currently overclaims completion unless those missing paths are implemented and tested.
Either broaden the implementation to fully close #14 or narrow the PR and split the remaining env requirements into follow-up issues.
8553740 to
6633033
Compare
Closes #14