Mark stored procedure parameters without defaults as required in OpenAPI

[Copilot]

Why make this change?

• Closes [Bug]: Required params not marked in OpenAPI #3498. The generated OpenAPI document for stored procedure entities omitted the required array on the {entity}_sp_request schema, so parameters that must be supplied (e.g. firstName, lastName) were not flagged as required.

What is this change?

• CreateSpRequestComponentSchema (OpenApiDocumentor.cs): a parameter is now marked required when it is explicitly flagged in config or has no default value. Previously only an explicit config required: true populated the array, which is almost never set, so the array was always empty.
  • Mirrors the existing IsRequestBodyRequired logic (!HasConfigDefault), keeping body-level and property-level required semantics consistent. An explicit config required: false is still honored.

if (def.Required ?? !def.HasConfigDefault)
{
    required.Add(parameter);
}

How was this tested?

• Integration Tests
• Unit Tests

Extended StoredProcedureGeneration.ValidateRequestBodyContents to assert the request body schema's required set contains the expected parameters. Verified the assertion fails when the fix is reverted.

Sample Request(s)

GET /api/openapi — request body schema component for a stored procedure with parameters title, publisher_name (neither having a default):

"sp1_sp_request": {
  "type": "object",
  "properties": {
    "title": { "type": "string" },
    "publisher_name": { "type": "string" }
  },
  "required": [ "title", "publisher_name" ]
}

[souvikghosh04]

@copilot please add tests from to support the changes

[Copilot]

@copilot please add tests from to support the changes

Added tests in StoredProcedureGeneration.ValidateRequestBodyContents covering all branches of the required-parameter logic:

• sp1: parameters without defaults are all required.
• sp2 (insert_book): a parameter with a config-provided default is not required.
• sp3 (update_book_title): a parameter explicitly marked required: false is not required.

Each entity uses a distinct stored procedure so per-entity config metadata doesn't cross-contaminate (entities sharing a source share the same parameter definition). Verified all rows pass with the fix and fail when it's reverted, against a local SQL Server. (79f... latest commit)

[Copilot]

Pull request overview

Updates OpenAPI generation for stored procedure entities so request schema components correctly flag parameters as required when no config default is available (while still honoring explicit required: false overrides), and extends integration coverage to validate the resulting required set.

Changes:

• Update stored procedure request schema generation to treat parameters as required when Required == true or when Required is unset and no config default exists.
• Extend OpenAPI integration tests to validate the schema component’s required parameters for stored procedure request bodies across default/override scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/Core/Services/OpenAPI/OpenApiDocumentor.cs	Adjusts stored procedure request schema generation to populate schema.Required based on config-required or absence of config default.
src/Service.Tests/OpenApiDocumentor/StoredProcedureGeneration.cs	Adds stored procedure entities and assertions to validate required parameters in the generated OpenAPI schema component.

[RubenCerna2079]

LGTM! Approving assuming comments from myself and copilot are resolved.

[souvikghosh04]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 6 pipeline(s).