fix(deps): loosen runtime dep pins to ranges in common.txt#92
Merged
Conversation
Exact == pins force downstream resolver conflicts for a library. Use floors/ranges instead; keep exact pins only in dev/test files. - requests>=2.31,<3 - pandas>=2.2,<4 (collapses the two python_version-marked lines; pip auto-skips pandas 3.0 on py3.10 since it requires >=3.11) Closes #86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loosen runtime dependency pins in
requirements/common.txt(the filepyproject.tomlexposes as the published runtime metadata viadynamic = ["dependencies"]). Exact==pins on a library force every downstream consumer to one version and cause pip resolver conflicts. Switched to compatible ranges; exact pins remain only inrequirements-dev.txt/requirements-test.txtwhere reproducibility matters.Closes #86
What changed
requirements/common.txt:pandas version verification (PyPI)
pandas==3.0.0does exist on PyPI (latest is 3.0.4). So the old pin was not broken-on-its-face, but exact-pinning is still wrong for a library.3.0.0declaresrequires-python >=3.11; pandas2.2declares>=3.9.requires-python = ">=3.10". The two python_version-marked lines collapse into a single rangepandas>=2.2,<4: pip's resolver honors each wheel'srequires-python, so on Python 3.10 it auto-skips 3.0.x and resolves a compatible 2.x, while 3.11+ gets the latest 3.0.x. No environment markers needed.requests: latest is 2.34.x, all<3; floor2.31is a sensible compatible floor.Test plan
requirements/common.txtlines parse viapackaging.requirements.Requirement.pip install .succeeds; resolves pandas 3.0.3 + requests 2.34.2;import datamaxiOK.pytest -p no:pep8: 10 passed, 151 skipped (skips require live API creds). Thepytest-pep8plugin errors on collection due to a pre-existing incompatibility with modern pytest — unrelated to this change.