Remove dead/broken tox stack (tox.ini + tox + tox-pyenv)#98
Merged
Conversation
CI invokes pytest/black/flake8 directly, never tox. tox-pyenv 1.1.0 abandoned + broken vs tox 4 (uses removed tox_get_python_executable hook); tox.ini envlist stale/malformed (py38/py39, 310/311). Drop tox.ini, tox/tox-pyenv from requirements-test.txt, .tox flake8 exclude. Closes #84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the dead/broken tox setup (same class as #81). CI (
.github/workflows/python-package.yml) runsblack/flake8/pytestdirectly and never invokes tox, so this is unused weight;tox-pyenv==1.1.0is abandoned and broken against tox 4 (implements the removedtox_get_python_executablehook), andtox.ini's envlist was stale/malformed (py38,py39,310,311).tox.initox+tox-pyenvfromrequirements/requirements-test.txt.toxfrom[flake8] excludeinsetup.cfgNo application code touched.
Test plan
flake8 . --statistics→ clean (exit 0)black --check --diff .→ clean (28 files unchanged)python -m pytest tests/→ 124 passed, 13 xpassed, 3 failed. The 3 failures are pre-existing live-endpoint flakiness (ReadTimeout / "no data found" from prod data), unrelated to this change — these are exactly the live-prod tests CI deliberately skips.Closes #84