Round-2 visual correctness: cutout transmission dedupe, 2D gamma, sharpen knob#76
Closed
proggeramlug wants to merge 1 commit into
Closed
Round-2 visual correctness: cutout transmission dedupe, 2D gamma, sharpen knob#76proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
…ma, sharpen knob - fs_main_scene's foliage backlit-transmission block was pasted TWICE (verbatim, 1.7x intended strength) and ran unshadowed — a canopy in another tree's shadow still glowed at full strength. Dormant in the shooter today (no MASK assets drawn) but a landmine for any cutout foliage. De-duplicated + multiplied by the sun shadow factor. (audit F3 side-finding) - 2D colors (shapes, textures, text) are now sRGB-decoded to linear before hitting the sRGB swapchain view — they were double-encoded: washed-bright HUD midtones, gamma-skewed glyph AA. Deliberately scoped to the 2D pass via a separate color_to_f32_srgb helper: the 3D immediate batch and model tints keep their historical raw /255 interpretation, because flipping those would silently re-tint every existing drawCube/drawModel call in shipped games. shapes_2d golden regenerated (midtones darken to their authored values); all 3D goldens unchanged. (audit F5) - New FFI `setSharpenStrength` / bloom_set_sharpen_strength: the composite unsharp mask was hardcoded 0.8 with no runtime control while visibly haloing silhouettes at 4K output. Default unchanged. (audit F8; manifest entry included — Perry silently no-ops undeclared natives) - docs/tickets.md: EN-021 (SSR+IBL exclusive ownership — deferred because a correct fix needs the env-miss fallback in the SSR pass, not just the ibl_spec complement) and EN-022 (motion vectors for material-system draws — the in-motion quality project).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 4, 2026
Contributor
Author
|
Landed in main via the round-2 consolidation merge (#83). All commits from this branch are now on main; closing as merged-through-integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #75 (round-2 stability). Three surgical correctness fixes from the audit, plus two tickets for the items that need real design work.
Duplicated cutout transmission (audit F3 side-finding)
fs_main_scene's foliage backlit-transmission block appears twice, verbatim — 1.7× the intended strength — and never multiplied by the sun shadow factor, so a canopy standing in another tree's shadow still glowed at full transmission. Dormant right now (the shooter draws no MASK assets on this path) but a landmine for any future cutout foliage. De-duplicated; survivor is shadowed.2D gamma (audit F5)
2D vertex colors (shapes, textured quads, glyph text) went into the sRGB swapchain view as raw
/255values — double-encoded, washing HUD midtones bright and skewing glyph AA. Now sRGB-decoded to linear, deliberately scoped to the 2D pass: the 3D immediate batch and model tints keep their historical interpretation, since flipping those would silently re-tint everydrawCube/drawModelin shipped games (verified by golden churn during development — the split leaves all 3D goldens byte-identical, onlyshapes_2dregenerates).Composite sharpen knob (audit F8)
setSharpenStrength/bloom_set_sharpen_strength— the unsharp mask was hardcoded at 0.8 with no runtime control, and it visibly halos high-contrast silhouettes at 4K output. Default unchanged; games can now tune or disable (0 skips the 4 extra HDR taps + extra tonemap). Manifest entry included.Tickets
ibl_specdown without an env fallback on SSR miss (today: black) would dim off-screen-reflection pixels — a worse artifact than the double-count. Full sketch in the ticket.Suite green: 99 lib + 7 golden.