Skip to content

327 refactor mission visualization#331

Open
kalynstricklin wants to merge 14 commits into
devfrom
327-refactor-mission-visualization
Open

327 refactor mission visualization#331
kalynstricklin wants to merge 14 commits into
devfrom
327-refactor-mission-visualization

Conversation

@kalynstricklin

Copy link
Copy Markdown
Contributor

@kalynstricklin

Copy link
Copy Markdown
Contributor Author

showing new mission vis layout
https://github.com/user-attachments/assets/0c778990-6840-4cfc-a512-c5f2b6530ffb

@kalynstricklin kalynstricklin marked this pull request as ready for review July 1, 2026 20:55
@salsajeries salsajeries self-requested a review July 2, 2026 14:52

@salsajeries salsajeries left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style/formatting changes

Comment on lines +1 to +6
export interface Waypoint {
id: string;
lat: number;
lon: number;
alt: number;
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend MapPoint

import { MapPoint } from '@/modules/map/adapters/types';

export interface Waypoint extends MapPoint {
  id: string;
}

</v-col>
</v-row>
</v-form>
</template>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<style scoped>
.field-floating-details {
	position: relative;
}

.field-floating-details :deep(.v-input__details) {
	position: absolute;
	top: 100%;
	left: 0;
	right: 0;
}
</style>

<v-row
density="comfortable"
cols="12"
class="d-flex align-start justify-center"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class="d-flex align-center justify-center pb-4"

cols="2.5"
xs="3"
>
<v-text-field

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class="field-floating-details"

cols="2.5"
xs="3"
>
<v-text-field

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class="field-floating-details"

Comment thread src/stores/mapstore.ts
Comment on lines +115 to +117
disableWaypointSelection();
isHomeLocationSelected.value = false;
isGeoPTZSelected.value = false;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with disselectAllTools()

Comment thread src/stores/mapstore.ts
Comment on lines +126 to +128
disableWaypointSelection();
isDriveLocationSelected.value = false;
isGeoPTZSelected.value = false;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with disselectAllTools()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Mission Builder has multiple different tools, maybe it should say which specific one is selected

}, name: string, label: string): Promise<{ layer: typeof PointMarkerLayer; props: any }> {
const vizId = `location-${randomUUID()}`;

const icon = await getColoredIconUrl(`${ICON_BASE}/icons/waypoint/round-pin.png`, '#00BFFF');

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider different home markers to distinguish from waypoints/drive to which are more navigation?

Home: https://pictogrammers.com/library/mdi/icon/home-map-marker/
Drive-to:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't pinpoint the cause of the issue, but LocationLayer icon color is different on Cesium vs. Leaflet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants