40 reviewing and adding missing tests

[Med-Yassine-B]

What changed?

• Reviewing Unit tests on argus for issue Audit and improve missing test coverage #40

• Commit details

• asserting error type by checking printed error
  • why? the function can return None and pass the test for diffrent reasons
• Fixing the error where ValueErros never thrown(check Notes/bugs found)
• Adding test case for check_error()
  • i suggest a default case in check_error() instead of silently failing
• changed tests again to assert for the default error instead of empty string from check_error()
• changed a return False into valid assert in test_get_a_full_timeseries()
• covered all operator in is valid op
• chenged a returning an error to "raise" to trigger the try/catch in get_timeseries()

• Notes

  • bugs found

  • keys accesing is being executed outside the try/catch block
  • key accesing is being executed using get()
    • // payload.get("key") never throws and erros but returns None silently should use payload["key"] instead
  • this causes the code to pass to the ckeck_error() and returns None withoute printing to the console
    • why? in check_error() there's no default case

Related issue #40

Closes #40

Tests

• I ran pytest
• Existing tests pass
• I added or updated tests where necessary
• Not needed because this only affects documentation or repository setup

Checklist

• The change is focused
• No secrets or API keys are included
• Documentation was updated if needed
• CI is expected to pass

Notes