Updated 'Copy Collection to Clipboard' menu item in the inventory view#10925
Updated 'Copy Collection to Clipboard' menu item in the inventory view#10925mrstarbuck007 wants to merge 10 commits into
Conversation
… Outputs the entire card collection, minus any cards in Auto-Sell, to the clipboard in Moxfield CSV format for easy importing.
mrstarbuck007
changed the title
Jetz72
left a comment
Jetz72
left a comment
There was a problem hiding this comment.
Seems like it'd be easier and more accurate to output the edition code and collector number rather than going through and grouping them by set.
| regexCardName = regexA.matcher(regexCardName).replaceAll("a"); | ||
| regexCardName = regexE.matcher(regexCardName).replaceAll("e"); | ||
| regexCardName = regexI.matcher(regexCardName).replaceAll("i"); | ||
| regexCardName = regexO.matcher(regexCardName).replaceAll("o"); | ||
| regexCardName = regexU.matcher(regexCardName).replaceAll("u"); |
There was a problem hiding this comment.
We do have StringUtils::stripAccents, but why wouldn't we want to export the oracle name?
There was a problem hiding this comment.
The Moxfield csv import can't handle accented characters so we need to replace them with the ASCII equivalents.
There was a problem hiding this comment.
Strikes me as something that'd ideally be fixed on their end, rather than making our end less correct and less consistent in order to have compatibility with an arbitrary platform. Have you tried reaching out to them?
…fies collector number and foil too
|
How about we don't try optimizing generic features for site-specific quirks? that seems like a neverending mess |
|
Because otherwise the feature is not very useful?
|
3 participants
Outputs the entire card collection, minus any cards in Auto-Sell, to the clipboard in Moxfield CSV format for easy importing.