fix(collections): fix 400 on cedar metadata re-submit#1023
Open
Vlad0n20 wants to merge 1 commit into
Open
Conversation
nsemets
reviewed
Jun 29, 2026
|
|
||
| handleAddToCollectionConfirm(): void { | ||
| const payload = this.config.data.payload; | ||
| const project = this.config.data.project; |
Collaborator
There was a problem hiding this comment.
Add a model here, similar to the one below.
nsemets
requested changes
Jun 29, 2026
| ? this.actions.createCedarRecord(cedarData, project.id as string, ResourceType.Project) | ||
| const saveCedar$: Observable<unknown> = cedarData | ||
| ? existingCedarRecord | ||
| ? this.actions.updateCedarRecord(cedarData, existingCedarRecord.id!, project.id as string, ResourceType.Project) |
Collaborator
There was a problem hiding this comment.
Suggested change
| ? this.actions.updateCedarRecord(cedarData, existingCedarRecord.id!, project.id as string, ResourceType.Project) | |
| ? this.actions.updateCedarRecord(cedarData, existingCedarRecord.id!, project.id, ResourceType.Project) |
Remove as string after adding model for project.
| const saveCedar$: Observable<unknown> = cedarData | ||
| ? existingCedarRecord | ||
| ? this.actions.updateCedarRecord(cedarData, existingCedarRecord.id!, project.id as string, ResourceType.Project) | ||
| : this.actions.createCedarRecord(cedarData, project.id as string, ResourceType.Project) |
Collaborator
There was a problem hiding this comment.
Remove as string after adding model for project.
Suggested change
| : this.actions.createCedarRecord(cedarData, project.id as string, ResourceType.Project) | |
| : this.actions.createCedarRecord(cedarData, project.id, ResourceType.Project) |
Collaborator
There was a problem hiding this comment.
Also remove in other places where you have it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes