add default value for MK_CONFDIR in ceph agent#894
Closed
fdriessler wants to merge 2 commits into
Closed
Conversation
fdriessler
commented
Feb 25, 2026
Member
|
@fdriessler Hello! Thank you for the patch and for making this consistent with the other agents! ❤️ I will get this merged soon, as Werk 19869. Apologies for the delay here! |
CheckmkCI
pushed a commit
that referenced
this pull request
Jun 19, 2026
When the environment variable `$MK_CONFDIR` was not set, the ceph agent would crash with a KeyError. This has been fixed and the default directory is now `/etc/check_mk/`, consistent with other agents. CMK-32386 #894 Change-Id: I5f92426b17da95ec51125c8393334f7564af74cb
CheckmkCI
pushed a commit
that referenced
this pull request
Jun 19, 2026
When the environment variable `$MK_CONFDIR` was not set, the ceph agent would crash with a KeyError. This has been fixed and the default directory is now `/etc/check_mk/`, consistent with other agents. CMK-32386 #894 Change-Id: I5f92426b17da95ec51125c8393334f7564af74cb
Member
|
This has merged into 2.5 and master as Werk 19869, thank you again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General information
This PR adds a default Value for the call on
MK_CONFDIRin the ceph agent.Proposed changes
Add a default Value for the call of os.environ['MK_CONFDIR']
os.environ['MK_CONFDIR'] -> os.environ.get('MK_CONFDIR', "/etc/check_mk")
We've run into a issue where a few hosts were unable to read this environment variable, causing the mk_ceph.py agent to fail.
My guess is that such a default value is already present in other agents in some shape or form, as the mk_ceph.py agent was the only one to have failed.