Update climate drivers for fire ESMValTool recipe timerange for CMIP6 and CMIP7 datasets#670
Open
jlenh wants to merge 15 commits into
Open
Update climate drivers for fire ESMValTool recipe timerange for CMIP6 and CMIP7 datasets#670jlenh wants to merge 15 commits into
jlenh wants to merge 15 commits into
Conversation
Author
|
I would need some feedback on the desired time ranges on which to run the climate drivers for fire recipe @douglask3 @rswamina |
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…_solve_regression.py
Author
|
I am running into an issue with the test Test output |
Contributor
|
You can update the expected output of the solve step by following these instructions: https://climate-ref.readthedocs.io/en/latest/development/#solver-regression-tests |
Author
Ah perfect, missed that, thanks Bouwe! |
Author
|
Test is running successfully following Bouwe's comment. I am however still waiting for a confirmation from Doug and Ranjini regarding the time period on which to run the recipe. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (5)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdates the fire climate driver timeranges for CMIP6 and CMIP7, including the constraint definitions, recipe year assignment logic, fixture YAMLs, recorded regression data, and changelog. CMIP6 shifts the start year to 1995, while CMIP7 shifts to 2002–2021. ChangesClimate Drivers for Fire — Time Range Updates
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 39c25055-c1c8-4e5b-8d67-4eb7f6a20067
📒 Files selected for processing (4)
changelog/670.trivial.mdpackages/climate-ref-esmvaltool/src/climate_ref_esmvaltool/diagnostics/climate_drivers_for_fire.pypackages/climate-ref-esmvaltool/tests/unit/diagnostics/recipes/recipe_climate_drivers_for_fire_cmip6.ymlpackages/climate-ref-esmvaltool/tests/unit/diagnostics/recipes/recipe_climate_drivers_for_fire_cmip7.yml
jlenh
commented
Jul 1, 2026
jlenh
left a comment
jlenh
left a comment
Author
There was a problem hiding this comment.
Changing time periods to:
- CMIP6: 1995 - 2014
- CMIP7: 2002-2021
Co-authored-by: Julien Lenhardt <45034763+jlenh@users.noreply.github.com>
jlenh
commented
Jul 1, 2026
Contributor
|
Thanks @jlenh. I'll remint some regression tests to verify that the diagnostic solved for me and then we are good to go |
…gnostics/climate_drivers_for_fire.py Co-authored-by: Jared Lewis <jared@jared.kiwi.nz>
…est case The version bump to 2 and the new run windows left both fire baselines stale. Remint the CMIP6 baseline against the new 1995-2014 window (diagnostic_version=2, test_case_version=2, native blobs uploaded to the public store). The CMIP7 test case cannot be minted: the recipe now runs CMIP7 over 2002-2021, but the only available CanESM5 historical test data ends in 2014, so the fetch resolves no datasets. Remove the CMIP7 regression test case and its baseline until real ESGF data covering that window is in the pipeline. The production CMIP7 data requirement is retained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the time periods used when running the climate drivers for fire recipe from ESMValTool, notably accounting for the timerange difference between CMIP6 and CMIP7 datasets. The timeranges are set as follows for now, but I am awaiting some further feedback on what these should be:
Checklist
Please confirm that this pull request has done the following:
changelog/Summary by CodeRabbit
Summary by CodeRabbit