SSF-225 FM Deleting & Editing Donation Item Backend#188
Conversation
There was a problem hiding this comment.
changes requested for codebase consistency!
let's have oz/value for donation items stay optional in the backend while the frontend requires them to match the create donation items & confirm item details contracts.
edit: i just saw your new pr up which updates those backend fields to be required & since it is better to match be + fe contracts and it's already implemented...let's keep it required in the be then, thanks for taking care of that :)
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
very very clean pr! few small things and one question worth discussing, but aside from that lgtm!
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
2 things, but imma approve since its pretty small.
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
LGTMMM!! just address one smol request & itll be good to go~+!
…ithub.com/Code-4-Community/ssf into jw/ssf-225-FM-edit-donation-items-backend
3 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-225
📝 Description
Added backend support for patch route donations/:donationId/item to allow adding, editing and deleting donation items for a donation.
✔️ Verification
Postman verified and service/controller tests
🏕️ (Optional) Future Work / Notes
N/A