Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 5 | Prep exercises#525
Open
M-Abdoon wants to merge 7 commits into
Open
Glasgow | 26-SDC-Mar | Mohammed Abdoon | Sprint 5 | Prep exercises#525M-Abdoon wants to merge 7 commits into
M-Abdoon wants to merge 7 commits into
Conversation
M-Abdoon
added
the
Needs Review
LonMcGregor
reviewed
Jun 3, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Some minor changes needed in the laptop code, otherwise good work
| matches = [] | ||
|
|
||
| for laptop in laptops: | ||
| if laptop.os == person.preferred_os: |
Contributor
There was a problem hiding this comment.
Can you consider a fallback, that way they still get an "imperfect" match if there are no preferred laptops left, or notify them somehow?
Author
There was a problem hiding this comment.
Thanks! I've added a fallback so that if no preferred OS matches are found, the user is notified and the available laptops are returned instead.
LonMcGregor
added
Reviewed
Author
|
Changes made! Thank you. |
M-Abdoon
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist