fix: remove dead --stream CLI flag (streaming is always used)#20
Merged
Coding-Dev-Tools merged 1 commit intoMay 19, 2026
Merged
Conversation
The --stream flag on the convert command and the corresponding stream parameter in the convert() function were dead code — all conversions always stream via read_stream()/write_stream(). Removed both to avoid misleading users into thinking there is a non-streaming mode. Closes a CLI UX issue where users could pass --stream expecting different behavior with no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --stream\ flag on the \convert\ command and the corresponding \stream\ parameter in the \convert()\ function were dead code — all conversions always stream via
ead_stream()/\write_stream(). Removed both to avoid misleading users into thinking there is a non-streaming mode.
Changes:
Tests: 84/84 pass, ruff clean