chore: remove dead protobuf support and unused helper#36
chore: remove dead protobuf support and unused helper#36Coding-Dev-Tools wants to merge 6 commits into
Conversation
- Adds include-package-data + [tool.setuptools.package-data] datamorph = ['py.typed'] - Adds known-first-party isort config for datamorph - Adds test_edge_cases.py with 13 tests (CLI convert/schema/batch/validate, detect_format none, get_reader/writer, packaging parity)
- test_batch_with_nonexistent_file: batch subcommand shows ERROR for missing file (cli.py:134-136) - test_detect_no_file: detect subcommand exits non-zero for nonexistent file (cli.py:142) - test_convert_nonexistent_file: convert subcommand shows error (cli.py:165-166) - Fix ruff I001 in test_edge_cases.py - 3 tests, 29 lines added. No __main__.py in this repo.
Review: changes requested — incomplete protobuf removal (functional regression)The intent to drop dead protobuf support is correct, but the removal is partial — the PR title says "remove dead protobuf support" yet Remaining protobuf references to remove (or keep + register)The PR removes protobuf from 2 locations. These 5 still reference it:
What to doPath (a) — complete removal (recommended, matches the PR title):
Path (b) — keep protobuf registered:
Recommend (a). The PR title says "remove dead protobuf support" and that's the cleanest outcome. Local test run: 130/130 tests pass, ruff clean, |
_avro_type(value)helper (never called; only_avro_type_for_schemais used)ProtobufConversionErrorexception class (never raised).proto/.pbffromdetect_format(no protobuf reader/writer registered; caused confusing 'Unsupported format' errors)full = [protobuf>=7.34.1]extra (protobuf is not implemented, and 7.34.1 is a non-existent version)130/130 tests pass. 0 ruff findings.