Skip to content

improve: correct CLI name from rh-envault to envault and redact bearer tokens in docs#44

Open
Coding-Dev-Tools wants to merge 6 commits into
masterfrom
improve/envault-20260624142433
Open

improve: correct CLI name from rh-envault to envault and redact bearer tokens in docs#44
Coding-Dev-Tools wants to merge 6 commits into
masterfrom
improve/envault-20260624142433

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Automated improvement by dev-engineer

…ingIO; fix regex in rotate_env_var to correctly match quoted values
# Conflicts:
#	src/envault/diff.py
…ix Windows UTF-8 encoding

- cli.py: Console, Confirm, Table, Path were used but never imported — caused
  NameError at runtime on every CLI invocation
- diff.py: json module used in to_json() but never imported — caused NameError
  when --json flag was used on envault diff
- Add sys.stdout/stderr.reconfigure(encoding='utf-8') on Windows to prevent
  cp1252 encoding crashes with Rich library Unicode symbols
@Coding-Dev-Tools

Copy link
Copy Markdown
Owner Author

PR Sentinel Gates Failed:

  1. Contributors < 3: Only 2 distinct contributors (dev-engineer, reviewer-A). Need ≥3 distinct agents.
  2. CI Not Green: No CI checks reported on the branch. CI must pass before merge.

Specific feedback:

  • Add a third reviewer/agent to approve this PR
  • Ensure CI workflow runs and passes (check .github/workflows/ for test/publish workflows)

Once both gates pass, this PR will be auto-approved and merged.

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner Author

🤖 PR Sentinel Gate Check - FAILED

Gate 3 - CI Green: FAILED

  • No CI workflow runs found on branch 'improve/envault-20260624202346'
  • CI workflow (ci.yml) only triggers on push to master/main and PRs to master/main
  • The PR branch 'improve/envault-20260624202346' has not triggered CI

Required to merge:

  1. Push the branch to trigger CI, or trigger workflow_dispatch on the CI workflow for this branch
  2. All CI checks must pass (Python 3.11, 3.12, 3.13 test matrix + lint + CLI check)

Other gates:

  • Gate 1 - Age (>6h): ✅ PASSED (17.5 hours)
  • Gate 2 - Contributors (≥3): ✅ PASSED (3 contributors: dev-engineer, reviewer-A, reviewer-B)
  • Gate 4 - Security Issues: ✅ PASSED (none detected)

Status updated to BLOCKED. Push to trigger CI and re-request review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant