test: add standalone dialect tests and converter edge cases#10
Merged
Coding-Dev-Tools merged 1 commit intoMay 18, 2026
Merged
Conversation
- Create tests/test_dialects.py with 48 tests covering: - Dialect enum values and membership - sql_type_for() for all types across PostgreSQL, MySQL, SQLite - quote_identifier() for all dialects (backtick vs double-quote) - format_value() edge cases: single quotes, booleans per dialect, None - create_table_sql() and insert_sql() including multi-row VALUES - Add converter edge case tests to test_converter.py: - Unsupported JSON root type (string, number, boolean) -> ValueError - generate_schema with flatten=True and nested arrays - generate_schema with primitive arrays - generate_schema with single object at root Coverage: 89% -> 96% (230 stmts, 10 uncovered, all optional license paths)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage: 89% -> 96% (230 stmts, 10 uncovered, all optional license paths)