check_drivesize: improve detection of drives out of the drive argument#410
Open
inqrphl wants to merge 2 commits into
Open
check_drivesize: improve detection of drives out of the drive argument#410inqrphl wants to merge 2 commits into
inqrphl wants to merge 2 commits into
Conversation
…t that user can type add tests that check both the status line and perdata labels using regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect and work with lowercase/uppercase , with or without semicolon, with or without slashes combinations of drive:
c
c:
c:
c:/
C
C:
C:
C:/
The previous version did not realize when C:\ was directly a drive, and tried to open it and match it to an existing drive.
This worked if it was a normal drive, but failed if it was a network mounted drive, the commit realizes that its a drive and directly uses stats provided by gopsutil. Otherwise it would try opening a handle to the drive root and fail, saying it was not mounted.
Add tests that check both the status line and perfdata labels using regex on all 8 combinations.
@sni check if the perfdata labels in tests look good.