Fix cache allowed hosts condition#411
Merged
Merged
Conversation
added 2 commits
July 14, 2026 15:12
…ed or unpopulated
AllowedHost.ResolveCache is populated lazily and not ahead of time during construction. In a race condition, multiple writes can overwrite eachother. if multiple connections are being established at the same time, which happens in different goroutines, they can run AllowedHost.Contains at the same time as well and overwrite the ResolveCache
sni
approved these changes
Jul 14, 2026
Contributor
|
looks good, can be merged once the unit tests are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two fixes:
fix if-else branch that checks if host cache is disabled or unpopulated
use a rw mutex for the resolvecache
AllowedHost.ResolveCache is populated lazily and not ahead of time during construction. In a race condition, multiple writes can overwrite eachother.
if multiple connections are being established at the same time, which happens in different goroutines, they can run AllowedHost.Contains at the same time as well and overwrite the ResolveCache
resolves #406