Skip to content

Java 5 migrations#3834

Open
jacomago wants to merge 15 commits into
ControlSystemStudio:masterfrom
jacomago:java-5-migrations
Open

Java 5 migrations#3834
jacomago wants to merge 15 commits into
ControlSystemStudio:masterfrom
jacomago:java-5-migrations

Conversation

@jacomago

Copy link
Copy Markdown
Contributor

Add auto fixes for Java 5 Migrations from InteliJ/sonarlint

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@jacomago jacomago self-assigned this Jun 16, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
8.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jacomago jacomago marked this pull request as ready for review June 16, 2026 13:14
@jacomago

Copy link
Copy Markdown
Contributor Author

FYI, this is pure static analysis fixes from Intelij/sonarlint tooling. No LLMs were harmed or abused in making this PR 😆

@shroffk

shroffk commented Jun 16, 2026

Copy link
Copy Markdown
Member

Ha,
So it looks like the vast majority of the changes were just the syntax of for loops ( get rid of the int i index )
+1

Using stringbuilder instead of stringbuffer
I did not check if the usage expected threadsafety.. but I am depending on the IDE to know.

There is also a lot of boxing of primitive types which is removed
+1

I am sure I have missed a few

@LuuOW LuuOW left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical audit: Implementation verified for system consistency and engineering integrity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants