Add locate-stone tool and docs#1593
Open
Koussy wants to merge 5 commits into
Open
Conversation
Linked with issue 2679. Introduce a new DFHack script (locate-stone.lua) and documentation (docs/locate-stone.rst). The tool is a fork of locate-ore that also detects stone and fuel sources by scanning mineral events. Flux stones are not mineral events and so was not able to add them. First draft so would appreciate any feedback.
This reverts commit 519e92d.
Linked with issue 2679. Add locate-stone.lua and accompanying docs/locate-stone.rst. The new DFHack script (a fork of locate-ore) scans mineral events for stone, ore and fuel sources. Linked with issue 2679. Fork of locate-ore that also shows stones and bituminous coal and lignite. Flux stones are not mineral events and so was not able to add them.
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Member
|
History has shown us that allowing someone to take an existing tool, copy its code, make changes to the copy, and then add that as a separate tool always leads to maintenance nightmares. This PR should, instead, generalize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DFHack/dfhack#2679
Introduce a new DFHack script (locate-stone.lua) and documentation (docs/locate-stone.rst). The tool is a fork of locate-ore that also detects stone and fuel sources by scanning mineral events. Flux stones are not mineral events and so was not able to add them.