fix(ci): gate Snap publish on SNAPCRAFT_STORE_CREDENTIALS presence#124
Merged
Conversation
Without this gate, every release shows Publish Snap as red because the secret is empty. Now the publish step is skipped (not failed) when the secret is unset, with a warning in the CI log. Build still runs so the snap artifact is validated on every release. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Publish Snapfails on every release withlogin_data is emptybecauseSNAPCRAFT_STORE_CREDENTIALSrepo secret is empty. The step has no guard, making the whole release page show red on Snap.Fix
HAS_SNAP_CREDS: ${{ secrets.SNAPCRAFT_STORE_CREDENTIALS != '' }}to job-level envif: env.HAS_SNAP_CREDS == 'true'::warning::annotation explaining how to enable publishingSnap build still runs on every release so the snap artifact is validated.
To enable Snap publishing
Founder must run:
and paste the output as
SNAPCRAFT_STORE_CREDENTIALSsecret at https://github.com/dakera-ai/dakera-cli/settings/secrets/actionsCloses DAK-7456.