fix(metrics_metadata): skip distribution-typed metrics in update path#633
Merged
riyazsh merged 1 commit intoJul 15, 2026
Merged
Conversation
The destination rejects PUT /api/v1/metrics/{name} for type=distribution
with 400 at the DB layer, so the request cannot succeed. Skip early to
avoid burning retries. Case- and whitespace-tolerant match. Fires before
the destination-existence probe. import_resource unchanged.
michael-richey
approved these changes
Jul 15, 2026
riyazsh
deleted the
riyaz/HAMR-392-T54-metrics-metadata-skip-distribution
branch
July 15, 2026 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The destination rejects
PUT /api/v1/metrics/{name}fortype=distributionwith 400 at the DB layer, so the request cannot succeed. Skip early to avoid burning retries. Case- and whitespace-tolerant match. Fires before the destination-existence probe so no wasted GET.import_resourceis unchanged — the source-side JSON still contains distribution entries for downstream consumers.Test plan
SkipResource, no destination HTTP calls (parametrized over lowercase / capitalized / uppercase / trailing-space variants).TestMetricsMetadataResourcesintegration test class is@pytest.mark.skip-ed attests/integration/resources/test_metrics_metadata.py:12, so the HTTP path is not exercised by CI.