Stop generating unused diffraction previews#378
Merged
Conversation
Contributor
Author
|
Updated I19 Mimas logic to create diffraction previews via the dedicated recipe for all data collections. Prior to this PR, I19 would create previews via the dedicated recipe only for eiger data collections and would rely on pia recipes to create the previews for pilatus. This likely resulted in duplicate previews for eiger collections. I15 Mimas logic has not been touched as it seems that the I15 Mimas handler was only added as a prototype and doesn't see any use in production. |
- Remove code for generating thumbnails
- Stop calling diffraction preview recipes for grid scans
- Ensure all rotation scans run the dedicated diffraction preview recipe
as the call to images in the pia recipes is set to be removed. In
some cases, this was causing duplication of diffraction previews.
The new precedent is that diffraction previews are generated by the
dedicated recipe and not by the pia recipes.
pblowey
force-pushed
the
stop-generating-unnecessary-thumbnails
branch
from
7b00b6b to
7fa5c30
Compare
Contributor
Author
|
Force pushed as unintended files were included in commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DiamondLightSource/mx-analysis/issues/77 and partially fixes https://github.com/DiamondLightSource/mx-analysis/issues/76.
Stop the images service from generating any thumbnails as these have not been used by SynchWeb for a long time.
Make mimas only run the generate-diffraction-preview recipe for rotation data collections. The recipes still make separate calls to the images service as well, which currently duplicates the diffraction previews. The calls to the images service in the recipes will need to be removed to fix this.