Backport slicing improvements to 0.25.x#280
Merged
apoelstra merged 13 commits intoJun 16, 2026
Merged
Conversation
Member
|
In 33ca246: This violates the MSRV. |
philipr-za
force-pushed
the
backport-slicing-improvements-0.25.x
branch
from
003617e to
45f2b3e
Compare
Author
|
Indeed, I only needed one helper from 278 actually so manually added that and dropped the rest of 278 |
philipr-za
force-pushed
the
backport-slicing-improvements-0.25.x
branch
6 times, most recently
from
0dc08fa to
8b9431c
Compare
philipr-za
force-pushed
the
backport-slicing-improvements-0.25.x
branch
from
8b9431c to
7d5f09c
Compare
These unwraps and indexing (which hide more panic paths) irritated me, and also would need to be tweaked once we get rid of the Hash::from_slice methods. I figured I'd preemptively get rid of them.
I don't *think* it's possible to create a rangeproof with a sidechannel smaller than 64 bytes (if you create a 0-sized "proof of exact value" then unwinding will fail entirely, and anything larger I think has at least one ring, so 128 bytes or more). Unsure. But better not to assume this by indexing recklessly into the sidechannel message.
We should redo the error types here as well at some point.
Currently we allow decoding segwit v0 programs which have uncompressed/hybrid keys (not allowed) and I suspect that if you provide a too-short address then you'll get a panic here.
philipr-za
force-pushed
the
backport-slicing-improvements-0.25.x
branch
from
7d5f09c to
5969790
Compare
Lol, this code was so close and yet so far. pset
philipr-za
force-pushed
the
backport-slicing-improvements-0.25.x
branch
from
5969790 to
982a50f
Compare
Member
|
utACK 982a50f |
Member
|
Tagged and published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a number of useful improvements from #279 we would like to include in 0.25.x.