fix(auth): stop expiring Plus One identity assertions#43
Merged
Conversation
JannikJung
force-pushed
the
codex/remove-plus-one-identity-freshness
branch
from
cbe6dc0 to
33db1e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plus One bootstrap assertions no longer fail only because
identity_verified_atis older than the previous receiver freshness window. Skill Library still validates the assertion signature, issuer, audience, subject, required workspace claims, and future-skew bounds; it just stops using link-proof age as an authorization gate.This keeps old but still-valid Plus One connections from requiring a manual Every relink while preserving the normal token/session and membership checks that actually determine access.
Validation
npx vitest run tests/auth/first-party-assertion.test.ts tests/routes/plus-one-oauth-client.test.ts --no-file-parallelism --maxWorkers=1 --maxConcurrency=1npm run build