refactor(tool-manager): integrate portability infrastructure across Tool Manager#603
Open
adarsh-7-satyam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Continuation of the Tool Manager portability and path resolution enhancement work.
This PR builds directly upon PR #571, which introduced the foundational portability infrastructure for the Tool Manager subsystem, including:
constants.pypaths.pyconfig.pyplatform_utils.pyregistry.pyPR #571 established the shared portability architecture while intentionally leaving the existing Tool Manager runtime unchanged. This PR completes the next phase by integrating that infrastructure into the core Tool Manager implementation.
Purpose
The primary objective of this PR is to integrate the portability infrastructure introduced in PR #571 into the existing Tool Manager runtime.
Rather than introducing new functionality, this PR replaces duplicated implementations with the centralized utilities established in PR #571. The focus is to improve maintainability, reduce code duplication, and ensure that the runtime actively uses the shared portability layer while preserving existing behavior.
Approach
This PR performs behavior-preserving integration of the portability infrastructure introduced in PR #571.
The major changes include:
paths.pyinto the Tool Manager runtime.constants.py.platform_utils.py.ConfigManager.main.pywhere the existing metadata matched exactly.Only integrations that were behaviorally equivalent were performed. Components whose data structures or semantics differed from the centralized infrastructure (such as GUI metadata and updater-specific version mappings) were intentionally left unchanged to avoid introducing functional regressions.
What This Achieves
With this PR:
Testing
ConfigManagerwith existinginformation.jsonfiles.feature/tool-manager-integrationbranch.