Skip to content

Farhana ic contributions#604

Open
Farhana-Farhana wants to merge 7 commits into
FOSSEE:masterfrom
Farhana-Farhana:farhana-ic-contributions
Open

Farhana ic contributions#604
Farhana-Farhana wants to merge 7 commits into
FOSSEE:masterfrom
Farhana-Farhana:farhana-ic-contributions

Conversation

@Farhana-Farhana

Copy link
Copy Markdown

Related Issues

N/A

Purpose

Add the following CA-series analog IC models to the eSim repository:

  • CA3005
  • CA3018
  • CA3019
  • CA3022
  • CA3028
  • CA3036
  • CA3054

Approach

Implemented and verified the above IC models using eSim and ngspice.

Each IC contribution includes:

  • Symbol files (.kicad_sym)
  • Subcircuit model files (.sub)
  • eSim/KiCad schematic files
  • Test circuits
  • Simulation output files
  • Required library files
  • Analysis and verification files

@dharunashokkumar

Copy link
Copy Markdown

Hey...
I have few suggestions on this pr to make this easier to review

The ic folders are currently at the repo root right.. per the convention used in merged pr #595 and pr #583, subcirc should go under libarary/subcircuitlibrary/'ic-name'/ , I think otherwise esim won't pick them as lib

most of the +253k lines is generated content that probably shouldn't be committed....... two fp-info-cache files are approx-87,500 lines each (about 69% of the PR by themselves), several folders contain a full copy of the entire esim_subckt symbol library (6,500 lines in CA3019_TEST1 it's even present twice, as CA3019.kicad_sym and esm_subckt.kicad_sym, which are identical files), plus .raw simulation dumps, _autosave..* files, and .kicad_prl files. removing these would be good and there will few hundred of lines as real ..

Minor: folder naming is inconsistent (CA3018_TEST1, ca3005_test, ca3028a_test2)

@dharunashokkumar

Copy link
Copy Markdown

Happy to help...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants