Fixes issue #417 - Open .kicad_sch subcircuit schematics in Edit Subcircuit#607
Open
dharunashokkumar wants to merge 1 commit into
Open
Conversation
…t Subcircuit Edit Subcircuit always launched eeschema with a hardcoded .sch path. Subcircuits saved with KiCad 6 use the .kicad_sch extension, so eeschema was pointed at a file that does not exist and kept prompting to create a new schematic instead of opening the existing one. Pick the .kicad_sch file when it exists and fall back to the legacy .sch file otherwise, the same way Kicad.py opens the main project schematic. New subcircuits are now created as .kicad_sch directly, in line with the project schematics from newProject.py.
Author
Tested on Windows 11 with KiCad 6.0.11 — Edit Subcircuit now opens the existing .kicad_sch straight away. Here it's opening the 2x1_mux subcircuit from the library; on master these same steps prompt you to create a new .sch instead.
|
dharunashokkumar
changed the title
Author
|
And also Fixes #274 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #417
problem: In eSim 2.5, KiCad 6 saves subcircuit schematics as .kicad_sch, but "Edit Subcircuit" always launches eeschema with a hardcoded .sch path. Since that file doesn't exist, eeschema keeps prompting to create a new schematic instead of opening the existing one.
Fix:
Tested both paths locally: a KiCad 6 subcircuit (e.g. 2x1_mux from the library) now opens correctly, legacy .sch subcircuits still open, and cancelling the folder dialog does nothing as before.