Fix scrying lens and related attributes, replace Accessories with Trinkets/Curios#1185
Merged
Conversation
This was
linked to
issues
Jul 1, 2026
Robotgiggle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we pull in Accessories and don't even take advantage of the fact it's multiloader. we already have a perfectly functional xplat curios/trinkets abstraction, just use it instead of using that abstraction to do curios/accessories for some reason
oh also I rolled some minor fixes that prevented the project from working at all on my puter into this. I can pull them out if needed
changes tested working on both NeoForge and Fabric, with Curios and Trinkets respectively.
fixes #1180, #1096, and #1123
conflicts with #1184