Stabilize particle-scenario weight normalization#4372
Draft
FlorianPfaff wants to merge 2 commits into
Draft
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bug
_normalized_particle_weights()summed validated finite weights directly:Individually finite nonnegative weights can still have a non-finite sum. For example,
[sys.float_info.max, sys.float_info.max / 2]has the well-defined ratio2:1, but its direct sum isinf. Dividing by that total produces[0.0, 0.0], so the particle-resampling scenario passes an invalid probability vector to the backend sampler.Fix
Scale all weights by their largest entry before summing. The scaled values lie in
[0, 1], retain the original ratios, and normalize to a finite unit-mass vector. Existing validation for length, finiteness, non-negativity, and positive mass is preserved.Validation
[0.0, 0.0]for maximum-finite weights[2/3, 1/3]with total mass1.0run_scenario()regression that parses the extreme weights from TOML and checks finite normalized metricsmainand zero behind; the production diff is 7 additions and 3 deletionsThe full backend test matrix is delegated to GitHub Actions.