Skip to content

Handle matrix sequence conversion runtime errors#4373

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/handle-matrix-sequence-runtime-conversion
Jul 14, 2026
Merged

Handle matrix sequence conversion runtime errors#4373
FlorianPfaff merged 2 commits into
mainfrom
agent/handle-matrix-sequence-runtime-conversion

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • treat backend RuntimeError during outer matrix-sequence conversion like the existing TypeError and ValueError cases
  • fall back to the established per-entry matrix normalization path
  • add a focused regression that simulates a backend unable to stack the outer sequence

Root cause

AbstractSmoother._normalize_matrix_sequence() first tries to convert the complete input sequence with the active backend's asarray(). Some backends raise RuntimeError, rather than TypeError or ValueError, when a Python sequence cannot be converted as one dense array. The vector-sequence counterpart already handles this backend behavior, but the matrix-sequence path did not. Consequently, valid per-step matrix sequences could fail before the existing per-entry fallback was reached.

Impact

Matrix sequence normalization now behaves consistently with vector sequence normalization and remains usable when a backend cannot stack the outer Python sequence directly. Inputs that are genuinely invalid still fail through the existing validation path.

Validation

  • branch is two commits ahead of current main and zero behind
  • production change is limited to one additional caught exception
  • regression monkeypatches the backend conversion to raise RuntimeError only for the outer sequence and verifies both matrices are normalized through the fallback

The full backend test matrix is delegated to GitHub Actions.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 22.72s
✅ JSON prettier 7 0 0 0 1.15s
✅ JSON v8r 7 0 0 3.63s
✅ MARKDOWN markdownlint 68 0 0 0 1.92s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.74s
✅ PYTHON black 1490 182 0 0 90.52s
✅ PYTHON isort 1490 328 0 0 2.49s
✅ REPOSITORY betterleaks yes no no 2.52s
✅ REPOSITORY checkov yes no no 55.9s
✅ REPOSITORY gitleaks yes no no 14.19s
✅ REPOSITORY git_diff yes no no 0.31s
✅ REPOSITORY secretlint yes no no 65.01s
✅ REPOSITORY syft yes no no 5.22s
✅ REPOSITORY trivy-sbom yes no no 6.14s
✅ REPOSITORY trufflehog yes no no 32.89s
✅ YAML prettier 11 0 0 0 0.68s
✅ YAML v8r 11 0 0 10.84s
✅ YAML yamllint 11 0 0 0.65s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff marked this pull request as ready for review July 14, 2026 20:12
@FlorianPfaff FlorianPfaff merged commit 22c87e9 into main Jul 14, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant