Stabilize measurement reliability covariance scaling#4374
Merged
FlorianPfaff merged 2 commits intoJul 14, 2026
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
max_scalecap before the power operation can underflow to zeroValueErrorwhen an uncapped scale cannot be represented as a finite floatBug
reliability_to_covariance_scale()computedbefore applying
max_scale. For large but finite exponents, the denominator can underflow to zero. The public helper then either returnedinfor raisedZeroDivisionError; an explicit finitemax_scalecould not protect the computation because it was applied too late.Fix
Compute the logarithm of the requested scale first. If it reaches a supplied finite cap, return that cap without evaluating the unstable power. If an uncapped result exceeds the largest finite float, raise a descriptive
ValueErrorrather than leaking an incidental arithmetic exception or infinity.Normal representable inputs still use the existing power expression, preserving current results and rounding behavior.
Validation
ZeroDivisionErrorwithreliability=0.5andexponent=1e67.0whenmax_scale=7.0ValueErrorcontainingcovariance scale overflowsmain