Skip to content

Copy bias model parameter arrays#4377

Draft
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/copy-bias-model-parameters-20260714
Draft

Copy bias model parameter arrays#4377
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/copy-bias-model-parameters-20260714

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • copy learned bias-model parameter arrays during construction
  • prevent caller-side NumPy mutations from silently changing a frozen model
  • add a focused regression covering stored parameters and prediction stability

Bug

SensorBiasCorrectionModel is a frozen dataclass, but np.asarray(..., dtype=float) can return caller-owned floating-point arrays unchanged. The constructor therefore retained aliases for intercept, coefficients, feature_mean, and residual_std. Mutating those input arrays after construction changed the model and its predictions.

Fix

Take owned copies of the parameter arrays when normalizing their shapes. feature_scale already becomes an owned array through its sanitizing np.where operation.

Validation

  • reproduced the pre-fix prediction change (3.0 to -105.0) after mutating constructor inputs
  • verified the patched prediction remains 3.0
  • PYTHONPATH=src python -m pytest -q tests/calibration/test_bias_parameter_ownership.py (1 passed)
  • Python compilation check passed for the modified module and regression test
  • branch comparison: two commits ahead, zero behind; only the calibration model and focused regression are changed

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 22.91s
✅ JSON prettier 7 0 0 0 0.94s
✅ JSON v8r 7 0 0 2.83s
✅ MARKDOWN markdownlint 68 0 0 0 2.01s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.64s
✅ PYTHON black 1490 183 0 0 94.65s
✅ PYTHON isort 1490 329 0 0 2.63s
✅ REPOSITORY betterleaks yes no no 2.2s
✅ REPOSITORY checkov yes no no 52.63s
✅ REPOSITORY gitleaks yes no no 14.83s
✅ REPOSITORY git_diff yes no no 0.38s
✅ REPOSITORY secretlint yes no no 61.15s
✅ REPOSITORY syft yes no no 6.25s
✅ REPOSITORY trivy-sbom yes no no 5.57s
✅ REPOSITORY trufflehog yes no no 33.5s
✅ YAML prettier 11 0 0 0 0.8s
✅ YAML v8r 11 0 0 10.44s
✅ YAML yamllint 11 0 0 0.61s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant