Skip to content

Fix MeasurementScore index ownership#4378

Closed
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/fix-measurement-score-index-ownership-20260714
Closed

Fix MeasurementScore index ownership#4378
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/fix-measurement-score-index-ownership-20260714

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • snapshot active_measurement_indices as an immutable tuple when constructing MeasurementScore
  • preserve existing list and NumPy-array inputs
  • add a regression test showing that mutating the caller-owned list no longer changes score.is_active

Root cause

MeasurementScore is a frozen dataclass, but it retained the caller's mutable index collection by reference. Clearing or appending to that collection after score construction silently changed the stored diagnostics and could flip is_active.

Validation

  • reproduced the old external-mutation failure
  • compiled the modified module with python -m py_compile
  • verified list and NumPy-array inputs are converted to a stable tuple
  • verified the branch differs from current main only in the implementation and focused regression test

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 22.19s
✅ JSON prettier 7 0 0 0 0.8s
✅ JSON v8r 7 0 0 4.79s
✅ MARKDOWN markdownlint 68 0 0 0 1.53s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.77s
✅ PYTHON black 1489 182 0 0 88.78s
✅ PYTHON isort 1489 327 0 0 2.15s
✅ REPOSITORY betterleaks yes no no 2.93s
✅ REPOSITORY checkov yes no no 50.21s
✅ REPOSITORY gitleaks yes no no 13.25s
✅ REPOSITORY git_diff yes no no 0.2s
✅ REPOSITORY secretlint yes no no 60.53s
✅ REPOSITORY syft yes no no 6.13s
✅ REPOSITORY trivy-sbom yes no no 5.76s
✅ REPOSITORY trufflehog yes no no 30.93s
✅ YAML prettier 11 0 0 0 0.61s
✅ YAML v8r 11 0 0 10.18s
✅ YAML yamllint 11 0 0 0.48s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review July 14, 2026 20:13
@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) July 14, 2026 20:13
auto-merge was automatically disabled July 15, 2026 05:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant