Skip to content

Reject complex hypertoroidal angle inputs#4381

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/reject-complex-hypertoroidal-inputs-20260714
Jul 14, 2026
Merged

Reject complex hypertoroidal angle inputs#4381
FlorianPfaff merged 2 commits into
mainfrom
agent/reject-complex-hypertoroidal-inputs-20260714

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • reject complex hypertoroidal shift vectors and evaluation points during shared input normalization
  • cover Python complex scalars, complex sequences, backend complex dtypes, and object arrays containing complex values
  • add a public wrapped-normal PDF regression that verifies validation happens before angle wrapping

Bug

The shared hypertoroidal input helpers document real-valued angles but only rejected boolean arrays. Complex values therefore passed shape validation. In HypertoroidalWrappedNormalDistribution.pdf(), they subsequently reached modulo-based angle wrapping and failed with a backend-dependent arithmetic error such as NumPy's TypeError from the remainder ufunc.

Fix

Detect complex scalar values, NumPy-style complex dtype kinds, backend dtype names containing complex, and object arrays containing complex entries before and after backend array conversion. Invalid callers now receive a stable, descriptive ValueError at the input boundary. Existing boolean and shape validation is unchanged.

Validation

  • reproduced the pre-fix behavior: [0.25 + 0.5j] passes shape normalization and later fails in modulo wrapping
  • isolated focused helper suite: 9 passed
  • verified scalar/vector real inputs preserve their existing normalized shapes
  • Python compilation passed for the modified helper and focused test reconstruction
  • branch comparison: two commits ahead of main, zero behind; one production file and one regression file changed

The full backend matrix is delegated to GitHub Actions.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 23.18s
✅ JSON prettier 7 0 0 0 1.12s
✅ JSON v8r 7 0 0 3.47s
✅ MARKDOWN markdownlint 68 0 0 0 1.83s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.44s
✅ PYTHON black 1490 182 0 0 92.98s
✅ PYTHON isort 1490 328 0 0 2.59s
✅ REPOSITORY betterleaks yes no no 2.54s
✅ REPOSITORY checkov yes no no 53.07s
✅ REPOSITORY gitleaks yes no no 15.25s
✅ REPOSITORY git_diff yes no no 0.46s
✅ REPOSITORY secretlint yes no no 58.83s
✅ REPOSITORY syft yes no no 5.1s
✅ REPOSITORY trivy-sbom yes no no 6.23s
✅ REPOSITORY trufflehog yes no no 31.97s
✅ YAML prettier 11 0 0 0 0.71s
✅ YAML v8r 11 0 0 11.45s
✅ YAML yamllint 11 0 0 0.58s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff marked this pull request as ready for review July 14, 2026 20:14
@FlorianPfaff FlorianPfaff merged commit 13e103e into main Jul 14, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant