Reject non-real wrapped Laplace rate parameters#4382
Draft
FlorianPfaff wants to merge 2 commits into
Draft
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
lambda_/kappa_inputs inWrappedLaplaceDistributionValueErrorRoot cause
_validate_positive_scalar()converted inputs with the active backend and then checked only shape, finiteness, andvalue > 0. NumPy considers some complex values greater than zero (for example,np.asarray(1 + 1j) > 0is true), and booleans also satisfy the positive-value check. The constructor could therefore accept non-real rate parameters and produce a complex-valued distribution even thoughlambda_andkappa_are documented as positive rates.Fix
Inspect the backend value through
to_numpy()before the arithmetic checks and require a real integer, unsigned-integer, or floating dtype. Complex, boolean, textual, temporal, and other non-real values now fail with a descriptiveValueError. Existing finite and positivity validation remains unchanged.Validation
True,1 + 1j, and one-element complex arrayspython -m py_compilepasses for the modified module and new regression testThe full backend matrix is delegated to GitHub Actions.