Skip to content

Validate and copy cost adjustment result matrices#4384

Merged
FlorianPfaff merged 2 commits into
mainfrom
agent/validate-cost-adjustment-result-20260714
Jul 14, 2026
Merged

Validate and copy cost adjustment result matrices#4384
FlorianPfaff merged 2 commits into
mainfrom
agent/validate-cost-adjustment-result-20260714

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • validate CostMatrixAdjustmentResult.adjusted_cost_matrix during direct construction
  • copy the validated matrix into result-owned storage
  • add focused regressions for caller-side mutation and invalid direct inputs

Root cause

CostMatrixAdjustmentResult is a frozen dataclass, but its __post_init__() only normalized diagnostics. The matrix field was stored exactly as supplied. A caller-owned NumPy array could therefore be mutated after construction and silently change an existing result. Direct construction also bypassed the cost-matrix validation used by the adjustment application helpers, allowing one-dimensional, NaN, negative-infinity, boolean, or complex matrices into the public result container.

Fix

Normalize the matrix through the existing _as_cost_matrix() validation path and store an owned copy in __post_init__(). This aligns direct construction with matrices returned through apply_cost_matrix_adjustment() while preserving valid positive-infinity entries.

Validation

  • reproduced caller-side mutation of the stored matrix before the fix
  • verified the result remains unchanged after mutating the original array
  • verified invalid direct constructions now raise ValueError
  • isolated focused validation passed locally
  • branch is two commits ahead of main, zero behind, and changes only the result container plus one regression file

The full repository test matrix is delegated to GitHub Actions.

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 24.22s
✅ JSON prettier 7 0 0 0 1.13s
✅ JSON v8r 7 0 0 4.38s
✅ MARKDOWN markdownlint 68 0 0 0 1.74s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.41s
✅ PYTHON black 1490 182 0 0 96.74s
✅ PYTHON isort 1490 328 0 0 2.68s
✅ REPOSITORY betterleaks yes no no 2.53s
✅ REPOSITORY checkov yes no no 56.58s
✅ REPOSITORY gitleaks yes no no 14.04s
✅ REPOSITORY git_diff yes no no 0.32s
✅ REPOSITORY secretlint yes no no 62.79s
✅ REPOSITORY syft yes no no 6.58s
✅ REPOSITORY trivy-sbom yes no no 6.69s
✅ REPOSITORY trufflehog yes no no 31.76s
✅ YAML prettier 11 0 0 0 0.78s
✅ YAML v8r 11 0 0 12.49s
✅ YAML yamllint 11 0 0 0.63s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff marked this pull request as ready for review July 14, 2026 20:16
@FlorianPfaff FlorianPfaff merged commit 3d3bbca into main Jul 14, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant