Validate and copy cost adjustment result matrices#4384
Merged
FlorianPfaff merged 2 commits intoJul 14, 2026
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
CostMatrixAdjustmentResult.adjusted_cost_matrixduring direct constructionRoot cause
CostMatrixAdjustmentResultis a frozen dataclass, but its__post_init__()only normalized diagnostics. The matrix field was stored exactly as supplied. A caller-owned NumPy array could therefore be mutated after construction and silently change an existing result. Direct construction also bypassed the cost-matrix validation used by the adjustment application helpers, allowing one-dimensional, NaN, negative-infinity, boolean, or complex matrices into the public result container.Fix
Normalize the matrix through the existing
_as_cost_matrix()validation path and store an owned copy in__post_init__(). This aligns direct construction with matrices returned throughapply_cost_matrix_adjustment()while preserving valid positive-infinity entries.Validation
ValueErrormain, zero behind, and changes only the result container plus one regression fileThe full repository test matrix is delegated to GitHub Actions.