Stabilize sliding-window manifold weights#4385
Merged
FlorianPfaff merged 3 commits intoJul 14, 2026
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
window_weightsduringSlidingWindowManifoldMeanSmootherconstructionsmooth()Root cause
The original implementation normalized weights directly with:
For individually finite values such as
[max_float, max_float / 2], the sum overflows. The first stabilization attempt instead used:That works with NumPy, PyTorch, and older JAX versions, but the CI-pinned JAX 0.10.2 lowers division by
float32.maxthrough reciprocal multiplication. The reciprocal underflows to zero, so both scaled weights become zero and the subsequent normalization produces NaNs. All three JAX matrix jobs failed when the downstream Dirac distribution rejected those non-finite weights; NumPy and PyTorch remained green.Fix
Validate that every configured weight is finite. For each active window, divide twice by the square root of its largest positive weight before normalizing:
Each divisor remains representable, avoiding JAX's extreme reciprocal underflow while retaining the original weight ratios.
Validation
[max_float, max_float / 2] / max_floatbecame[0, 0][2/3, 1/3][0, 3]returns approximately[0, 1]The full GitHub Actions matrix is running on the updated branch.