Use covariance weights in hyperspherical arbitrary-noise prediction#4386
Draft
FlorianPfaff wants to merge 2 commits into
Draft
Use covariance weights in hyperspherical arbitrary-noise prediction#4386FlorianPfaff wants to merge 2 commits into
FlorianPfaff wants to merge 2 commits into
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Wc) when computing covariance inHypersphericalUKF.predict_nonlinear_arbitrary_noise()Wmproduct weights for the predicted meanRoot cause
The arbitrary-noise path constructed one Cartesian-product weight vector from
points.Wmand reused it for both the mean and covariance. Merwe sigma points define separate mean and covariance weights; the central covariance weight includes the1 - alpha^2 + betacorrection. ReusingWmtherefore ignoredbetaentirely and could produce a negative diagonal covariance entry for a valid positive-definite prior.Impact
Arbitrary-noise hyperspherical predictions now preserve the intended scaled-unscented-transform covariance. The reproduced two-dimensional identity case changes the first predicted variance from approximately
-9.48e-4to the correct positive value4.26e-3.Validation
tests/filters/test_hyperspherical_ukf_covariance_weights.py1 passedpython -m py_compileruff check --select F821,F822,F823on both changed Python files: passed