Skip to content

Use covariance weights in hyperspherical arbitrary-noise prediction#4386

Draft
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/fix-hyperspherical-ukf-covariance-weights
Draft

Use covariance weights in hyperspherical arbitrary-noise prediction#4386
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/fix-hyperspherical-ukf-covariance-weights

Conversation

@FlorianPfaff

@FlorianPfaff FlorianPfaff commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • use Merwe covariance weights (Wc) when computing covariance in HypersphericalUKF.predict_nonlinear_arbitrary_noise()
  • keep the probability-normalized Wm product weights for the predicted mean
  • add a focused regression that compares against the explicit unscented-transform covariance

Root cause

The arbitrary-noise path constructed one Cartesian-product weight vector from points.Wm and reused it for both the mean and covariance. Merwe sigma points define separate mean and covariance weights; the central covariance weight includes the 1 - alpha^2 + beta correction. Reusing Wm therefore ignored beta entirely and could produce a negative diagonal covariance entry for a valid positive-definite prior.

Impact

Arbitrary-noise hyperspherical predictions now preserve the intended scaled-unscented-transform covariance. The reproduced two-dimensional identity case changes the first predicted variance from approximately -9.48e-4 to the correct positive value 4.26e-3.

Validation

  • added tests/filters/test_hyperspherical_ukf_covariance_weights.py
  • ran the regression against a main-equivalent method: failed with the incorrect negative variance
  • ran the same regression against the patched method: 1 passed
  • compiled the patched module and regression with python -m py_compile
  • ran ruff check --select F821,F822,F823 on both changed Python files: passed
  • GitHub Actions matrix is queued for the draft PR

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 24.52s
✅ JSON prettier 7 0 0 0 0.98s
✅ JSON v8r 7 0 0 3.17s
✅ MARKDOWN markdownlint 68 0 0 0 2.06s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.82s
✅ PYTHON black 1490 183 0 0 96.44s
✅ PYTHON isort 1490 329 0 0 2.63s
✅ REPOSITORY betterleaks yes no no 2.34s
✅ REPOSITORY checkov yes no no 56.83s
✅ REPOSITORY gitleaks yes no no 15.2s
✅ REPOSITORY git_diff yes no no 0.32s
✅ REPOSITORY secretlint yes no no 59.95s
✅ REPOSITORY syft yes no no 5.72s
✅ REPOSITORY trivy-sbom yes no no 6.04s
✅ REPOSITORY trufflehog yes no no 32.08s
✅ YAML prettier 11 0 0 0 0.74s
✅ YAML v8r 11 0 0 12.21s
✅ YAML yamllint 11 0 0 0.76s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant